tcgoetz / GarminDB

Download and parse data from Garmin Connect or a Garmin watch, FitBit CSV, and MS Health CSV files into and analyze data in Sqlite serverless databases with Jupyter notebooks.
GNU General Public License v2.0
1.11k stars 137 forks source link

Problem with Release 1.8 - garmin.py #81

Closed ParzivalWins closed 3 years ago

ParzivalWins commented 3 years ago

100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [00:15<00:00, 1.54s/activities] Traceback (most recent call last): File "garmin.py", line 340, in File "garmin.py", line 321, in main File "garmin.py", line 125, in download_data File "garmin.py", line 71, in __get_date_and_days TypeError: '<' not supported between instances of 'NoneType' and 'int' [6473] Failed to execute script garmin

fricour commented 3 years ago

Hi, Same issue here. image

karlicoss commented 3 years ago

Looks like it happened in this commit.

Changing this line https://github.com/tcgoetz/GarminDB/blob/265678bf9eae074ccc2fbd6d1555d204575e77f2/garmin_connect_config_manager.py#L73 to days = (datetime.datetime.now().date() - date).days fixes the issue, although not sure if it's the right thing to do.

tcgoetz commented 3 years ago

Added to develop branch.