tchapgouv / tchap-android

A matrix client for Android.
https://play.google.com/store/apps/details?id=fr.gouv.tchap.a
Apache License 2.0
21 stars 7 forks source link

Study impact of Spaces activation #902

Open NicolasBuquet opened 1 year ago

NicolasBuquet commented 1 year ago

Spaces will be activated on web client. Study possible impact on mobile client. Is it worth activating button "Change space"?

NicolasBuquet commented 1 year ago

Spaces displaying is conditioned by a few flags :

Setting `SHOW_SPACES' to True activate the Spaces button on the home list.

image image

When displaying TimelineView coming from a notification, if Spaces are not unified (prefSpacesShowAllRoomInHome is false), the application will try to activate the space related to the room notification if no space is already activated.

Cf. im/vector/app/features/home/room/detail/TimelineVIewModel method intiSafe()

// We are coming from a notification, try to switch to the most relevant space
// so that when hitting back the room will appear in the list

When displaying unread messages, if prefSpacesShowAllRoomInHome is false, it will filter orphans rooms (rooms that are no longer in any space). (cf. im/vector/app/features/home method init())

When the setting is exposed in Settings, it will restart the activity if the value of SETTINGS_PREF_SPACE_SHOW_ALL_ROOM_IN_HOME is toggled. (cf. im/vector/app/features/settingsmethodbindPrefs()`)

And when displaying the room list, if prefSpacesShowAllRoomInHome is false, it will display only orphans rooms if no space is actually selected. (cf. im/vector/app/features/home/room/listpropertyroomListSectionBuilder`)

The impact doesn't seem big. Some conscientious testing is needed of course.

NicolasBuquet commented 1 year ago

Activation des Espaces sur Tchap Android :

L'activation des Espaces sur Tchap Android se fait par le biais du feature flag SHOW_SPACES. Il faut aussi remettre le panneau de présentation.

Une fois activé, l'option activée, un nouveau bouton flottant apparait au dessus du bouton de création de message :

Capture d’écran 2023-04-21 à 11 41 40

Bouton "Espaces"

Au clic, si aucun espace n'est disponible, un menu propose la création d'un espace :

Capture d’écran 2023-04-21 à 11 42 01

Menu création d'espaces

Cela s'enchaîne par la création d'un salon

Screenshot_20230421_114210 Screenshot_20230421_114224 Screenshot_20230421_114258

Une fois un salon créé le menu permet de basculer d'un salon à l'autre :

Capture d’écran 2023-04-21 à 11 43 20