tchapgouv / tchap-android

A matrix client for Android.
https://play.google.com/store/apps/details?id=fr.gouv.tchap.a
Apache License 2.0
19 stars 7 forks source link

Rebase/element android 1.6.2a #944

Closed NicolasBuquet closed 1 year ago

NicolasBuquet commented 1 year ago

Fix #941

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [4304253](https://dashboard.gitguardian.com/incidents/4304253?occurrence=100384254) | Generic High Entropy Secret | eba31a7216c0bff7a7e73ca991a702822a4a77cf | vector-config/src/main/java/im/vector/app/config/Config.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/eba31a7216c0bff7a7e73ca991a702822a4a77cf#diff-0f1ccce4dd77f87c2b817a35f1a287de16842febfa120a18d68e56cfd3e35a48L87) | | [4304253](https://dashboard.gitguardian.com/incidents/4304253?occurrence=100384257) | Generic High Entropy Secret | 30b5095a7c88fdb565d55b95ae9e6dd924dcd10a | vector-config/src/main/java/im/vector/app/config/Config.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/30b5095a7c88fdb565d55b95ae9e6dd924dcd10a#diff-0f1ccce4dd77f87c2b817a35f1a287de16842febfa120a18d68e56cfd3e35a48L91) | | [4304253](https://dashboard.gitguardian.com/incidents/4304253?occurrence=100384258) | Generic High Entropy Secret | c9ed3abc36d670a0f540132e63bbdad6d3428134 | vector-config/src/main/java/im/vector/app/config/Config.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/c9ed3abc36d670a0f540132e63bbdad6d3428134#diff-0f1ccce4dd77f87c2b817a35f1a287de16842febfa120a18d68e56cfd3e35a48L87) |
🛠 Guidelines to remediate hardcoded secrets
1. Revoke and rotate the secret. 2. If possible, rewrite git history with `git commit --amend` and `git push --force`.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

tchap-danger-bot[bot] commented 1 year ago
Warnings
:warning: You seem to have made changes to views. Please consider adding screenshots.
Messages
:book: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against b264d1afb3160d19fef7fb8650d1f93842b07223

tchap-danger-bot[bot] commented 1 year ago
Warnings
:warning: You seem to have made changes to views. Please consider adding screenshots.
Messages
:book: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 7e0f1222f685d900150ee64009a6ce7f7e546772

tchap-danger-bot[bot] commented 1 year ago
Warnings
:warning: You seem to have made changes to views. Please consider adding screenshots.
Messages
:book: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 447da92103dc5ce0e54f5310e5ce058b2c07a94c

tchap-danger-bot[bot] commented 1 year ago
Warnings
:warning: You seem to have made changes to views. Please consider adding screenshots.
Messages
:book: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 34806cf7c4d939d3860bf8dffb2ba7d9c0ced2d9

tchap-danger-bot[bot] commented 1 year ago
Warnings
:warning: You seem to have made changes to views. Please consider adding screenshots.
Messages
:book: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 651367df8d155e8135e2abb79dfadd503510042c

tchap-danger-bot[bot] commented 1 year ago
Warnings
:warning: You seem to have made changes to views. Please consider adding screenshots.
Messages
:book: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against e63ebfc1ce9fa46d3c6c639cec5feb9c591de0de

tchap-danger-bot[bot] commented 1 year ago
Warnings
:warning: You seem to have made changes to views. Please consider adding screenshots.
Messages
:book: This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against bbb21072dcf51cf422b683b2cc03dcebff1eae68