Fix crypto migration for mono session

yostyle commented 12 months ago

Type of change

[ ] Feature
[x] Bugfix
[ ] Technical
[ ] Other :

Content

An issue could occurs when decrypting message if keys are not found with other sessions which can happen for users who have only one session. We try to perform a lazy migration from the legacy store if there is no other session.

Motivation and context

Users that have only one session could have an issue when decrypting message since the Rust migration.

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

[ ] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes has been tested on an Android device or Android emulator with API 21
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#accessibility
[x] Pull request is based on the develop branch
[ ] Pull request updates TCHAP_CHANGES.md
[x] Pull request includes a new file under ./changelog.d. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#changelog
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR
[ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

tchap-danger-bot[bot] commented 12 months ago

	Warnings
:warning:	Please add a changelog. See instructions [here](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog)

Generated by :no_entry_sign: dangerJS against 3c2a9d30855e250b37956003bd50b746b2221bf5

mcalinghee commented 12 months ago

Communication :

[ ] communication ciblée au users qui ont crée un ticket
[ ] communication ciblée aux users qui ont une seule session android en 2.9.2 - 2.9.3
[ ] campagne globale : migrer à la derniere version

27k utilisateurs ont installé cette version 2.9.3. 70% d'user mono mobile : https://stats.tchap.incubateur.net/question/82-repartition-mobile-et-web-dernier-mois 2.9.3 = 27k personnes le risque : quelqu'un en 2.9.3 qui vide son cache perd tous ses messages

Communiquer ? : "la 2.9.3 présente une instabilité sur Android. Ne pas vider le cache sous peine d'empirer la situation."

cc @odelcroi @yostyle @NicolasBuquet

tchapgouv / tchap-android