tchapgouv / tchap-android

A matrix client for Android.
https://play.google.com/store/apps/details?id=fr.gouv.tchap.a
Apache License 2.0
19 stars 7 forks source link

Fix email address pattern #982

Closed yostyle closed 8 months ago

yostyle commented 8 months ago

Type of change

Content

Update email validation in accordance with RFC 5322

Screenshots / GIFs

Tests

Tested devices

Checklist

tchap-danger-bot[bot] commented 8 months ago
Warnings
:warning: Please add a changelog. See instructions [here](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog)

Generated by :no_entry_sign: dangerJS against 37a4661c0db36ec7719df3f2e11b610edaf639ea

yostyle commented 8 months ago

Does the modification in TchapLoginWizard class (login is only authorized by email address) will prevent us to have account with no email address attached (as see in rageShake data) ?

I will check this but on Tchap Android it's always mandatory to use an email address to sign in in the app. https://github.com/tchapgouv/tchap-android/blob/develop/vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthLoginFragment.kt#L142