Update secure flag - Githubissues

yostyle commented 8 months ago

Type of change

[ ] Feature
[ ] Bugfix
[ ] Technical
[x] Other :

Content

Secure flag management improvement

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

[ ] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes has been tested on an Android device or Android emulator with API 21
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#accessibility
[x] Pull request is based on the develop branch
[ ] Pull request updates TCHAP_CHANGES.md
[ ] Pull request includes a new file under ./changelog.d. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#changelog
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR
[ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

tchap-danger-bot[bot] commented 8 months ago

	Warnings
:warning:	Please add a changelog. See instructions [here](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog)

Generated by :no_entry_sign: dangerJS against 85a56c04787285df95a6a4033d4f55b9f76c2eb7

yostyle commented 8 months ago

In your version, screenshots are allowed for F-droid version.

This should not be allowed.

I don't think so. The rule is !(BuildConfig.FLAVOR_store == "gplay" && BuildConfig.FLAVOR_target != "tchap"). It returns true (useFlagSecure) if FLAVOR_store != "gplay" (ex. fdroid)