Rebase against element android 1.6.8

yostyle commented 6 months ago

Type of change

[ ] Feature
[ ] Bugfix
[x] Technical
[ ] Other :

Content

Rebase against element android 1.6.8

Motivation and context

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

[x] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes has been tested on an Android device or Android emulator with API 21
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#accessibility
[x] Pull request is based on the develop branch
[ ] Pull request updates TCHAP_CHANGES.md
[ ] Pull request includes a new file under ./changelog.d. See https://github.com/tchapgouv/tchap-android-v2/blob/develop/CONTRIBUTING.md#changelog
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR
[ ] If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

tchap-danger-bot[bot] commented 6 months ago

	Warnings
:warning:	Please add a changelog. See instructions [here](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog)

	Messages
:book:	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 9da0464c4ab35e3f24c2187a79d22bf5cbd533b4

tchap-danger-bot[bot] commented 6 months ago

	Warnings
:warning:	Please add a changelog. See instructions [here](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog)

	Messages
:book:	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against f1b65aeb44ee85bdfce76d4611e0f1bd0079520e

gitguardian[bot] commented 6 months ago

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121492588) | Generic Password | 979324da842a55de67fa27e4f54ee0bd61068d40 | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/979324da842a55de67fa27e4f54ee0bd61068d40#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5R264) | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121492589) | Generic Password | 77a576784f4de8007965739d331d466a2759c40e | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/77a576784f4de8007965739d331d466a2759c40e#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5R264) | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121492590) | Generic Password | 552b143f8cf7238586722e629102eb0482b9e93e | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/552b143f8cf7238586722e629102eb0482b9e93e#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5R264) | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121492591) | Generic Password | 979324da842a55de67fa27e4f54ee0bd61068d40 | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/979324da842a55de67fa27e4f54ee0bd61068d40#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5L264) | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121492592) | Generic Password | 77a576784f4de8007965739d331d466a2759c40e | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/77a576784f4de8007965739d331d466a2759c40e#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5L264) | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121492593) | Generic Password | 552b143f8cf7238586722e629102eb0482b9e93e | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/552b143f8cf7238586722e629102eb0482b9e93e#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5L264) | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121685771) | Generic Password | cd98953c635c52615cb322909099b805061c2c8c | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/cd98953c635c52615cb322909099b805061c2c8c#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5L264) | | [7196668](https://dashboard.gitguardian.com/incidents/7196668?occurrence=121685772) | Generic Password | cd98953c635c52615cb322909099b805061c2c8c | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt | [View secret](https://github.com/tchapgouv/tchap-android/commit/cd98953c635c52615cb322909099b805061c2c8c#diff-6343f6299e0b3361b217c20cf55bfffa7def5bf79fad49ebf1342f17c5463cb5R264) |

🛠 Guidelines to remediate hardcoded secrets

1. Revoke and rotate the secret. 2. If possible, rewrite git history with `git commit --amend` and `git push --force`.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

tchap-danger-bot[bot] commented 6 months ago

	Warnings
:warning:	Please add a changelog. See instructions [here](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog)

	Messages
:book:	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 3f0a923c84a918097b237ff43ac183ead59f5b3d

tchap-danger-bot[bot] commented 6 months ago

	Warnings
:warning:	Please add a changelog. See instructions [here](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog)

	Messages
:book:	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 5c96092cfd40d2c886c5306243ea1ea7242fb6e1

tchap-danger-bot[bot] commented 6 months ago

	Messages
:book:	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 77fa43d6db66e965eab70b910bef4aa974b7c675

tchap-danger-bot[bot] commented 6 months ago

	Messages
:book:	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against 306729c15d993906e5c5601b7e08e9eca22197fc

tchap-danger-bot[bot] commented 6 months ago

	Messages
:book:	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by :no_entry_sign: dangerJS against cd98953c635c52615cb322909099b805061c2c8c

tchapgouv / tchap-android