tchapi / Adafruit-GFX-Font-Customiser

A little utility to customise pixel fonts for the Adafruit GFX library
https://tchapi.github.io/Adafruit-GFX-Font-Customiser/
MIT License
90 stars 47 forks source link

Export: Create new glyphs entries when export range is outside of contained glyphs. #16

Closed charno closed 3 years ago

charno commented 3 years ago

This is usable for example when you want to add new characters to a font only containing standard ascii characters.

I used this for a font exporting from 0x20 to 0x7E, when I wanted to add the ° symbol. First I imported the existing font, then I exported with "Last glyph to export" == "0xFF". Then I took the result and imported again, so I could edit the newly added symbols.

tchapi commented 3 years ago

Hi @charno and thanks for that,

I'm just wondering if this wouldn't be easier and more user-friendly to add a button that can add directly a new "blank" glyph at the end of the range ? It would avoid the useless export/reimport step I guess

What do you think ?

charno commented 3 years ago

Hi @tchapi

I don't know about easier (I'm by no means experienced in JS).

From a users perspective I can see that this would make more sense. Then I would suggest to allow to add a number of items at a time (since when the button only adds one blank glyph I woud have to click about 100 times to go from 0x7E to °).

This was just the implementation that I as a JS noob could come up with in a reasonable time, and I thought that it could be useful for other people as well.

tchapi commented 3 years ago

Hi @charno

Would you mind testing https://github.com/tchapi/Adafruit-GFX-Font-Customiser/pull/17 and tell me if that suits your needs ? You can add a character (directly in a modal), and it will automatically add the interval characters needed for the output file, disabling them so they don't take that much space.

It should work properly but I'm not sure I have covered all edge cases.

Thanks in advance ! Cyril

charno commented 3 years ago

Superseeded by #17 / #18