Closed charno closed 3 years ago
Added some documentation changes
And a last change for today: The trailing _ from an imported font name is removed when displaying. Also, there are no empty parentheses before a font is loaded or created.
Oh my. This is huge 🤩 !
I will have a thorough look at that tomorrow and keep you posted.
Thanks a lot
And one more small change :)
@charno can you allow 'Edits from maintainers' on this PR so I can push little changes too ?
Hmm... The checkbox was active. Maybe you couldn't push because it was in draft mode? I changed to normal pull request now, please check again.
🎉
Yeah, thanks a lot!
Hi,
Holidays are boring when there's not a lot to do outside the house. So I sat down and wrote the feature to create a new font.
In this pull request it's a bit a mixture, since I touched some related bits in the code.
There are:
Please have a look at it. If it's a problem for you that the commits are mixed and chaotic I can do some cleanup work. Otherwise I'm open for all sorts of change requests, I tried to copy your coding style and do a reasonable job on the JS side, but as I said normally I'm coding in C++...
I did some testing and created this very ugly font which I will never use again, but it did work on my display!