search

tchapi / Adafruit-GFX-Font-Customiser

A little utility to customise pixel fonts for the Adafruit GFX library
https://tchapi.github.io/Adafruit-GFX-Font-Customiser/
MIT License
90 stars 47 forks source link

GFXglyph output formating to include hex representation of character #23

Closed mestrode closed 3 years ago

mestrode commented 3 years ago 
  {  3579,  17,  19,  19,    1,  -18 },   // 0x6F 'o'

instead of 

 ,{  3579,  17,  19,  19,    1,  -18 }   // 'o'
tchapi commented 3 years ago

Hello and thanks for your contribution. I've made some small comments if you want to have a look, then I can merge your PR

BR

mestrode commented 3 years ago

there was a issue with non prinable characters, I covered this within this commit.

  {     0,   0,   0,   0,    0,    0 },   // 0x1F non printable, disabled
  {     0,   0,   0,   0,    0,    0 },   // 0x20 " ", disabled
  {     0,   3,  26,  12,    4,  -25 },   // 0x21 "!"
  {    11,   9,   9,  12,    1,  -24 },   // 0x22 """

Side question: The painting of characters will be more easy if it would be possible to shift the mouse by pressing the mouse button over several pixel. And they should be all activated or maybe just switched. This behavior would be more like common known form apps like paint or so. How can this be implemented? I don't fully understand the file.

tchapi commented 3 years ago

Understood for the shift + mouse painting, I can have a look at that !

mestrode commented 3 years ago

wait, I switched from single quote ' to double quote " unintentionally, will adjust this

mestrode commented 3 years ago

Understood for the shift + mouse painting, I can have a look at that !

That would be nice. very appreciated! Maybe just draging the mouse while hold down the mouse button will be a bit more intuitive. This was unclear written by me.

Quotes are adjusted, so you can merge the request, if you like to.

Thank you very much!

tchapi commented 3 years ago

Thanks a lot @mestrode !

tchapi commented 3 years ago

@mestrode would you be kind enough to test the latest commit to see if it works well ? I implemented the "mouse painting"