search

tchapi / Adafruit-GFX-Font-Customiser

A little utility to customise pixel fonts for the Adafruit GFX library
https://tchapi.github.io/Adafruit-GFX-Font-Customiser/
MIT License
90 stars 47 forks source link

copy & paste #33

Open m4xr1sk opened 2 years ago

tchapi commented 2 years ago

Hi What is the purpose of this PR ?

Thanks

m4xr1sk commented 2 years ago

I have added the buttons copy and paste to each chars. I need some special chars with accents for french, spanish, etc. so I think to extract the full range of chars from a font and then remap the ones that I need in some unused pos.

Il sab 29 gen 2022, 12:12 tchap @.***> ha scritto:

Hi What is the purpose of this PR ?

Thanks

— Reply to this email directly, view it on GitHub https://github.com/tchapi/Adafruit-GFX-Font-Customiser/pull/33#issuecomment-1024891013, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ3UKUQO4ADICUIN2BRVHLUYPDRXANCNFSM5NCQNRMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

tchapi commented 2 years ago

It seems that they are a lot of changes in your commits that are not related to that (putting scripts in different files, indentation, etc) so I cannot merge as-is.

Try to extract that specific feature (copy & paste) so the changeset is readable and contained so I can review it

thanks !

m4xr1sk commented 2 years ago

Ok, I'll do that.

Il sab 29 gen 2022, 13:59 tchap @.***> ha scritto:

It seems that they are a lot of changes in your commits that are not related to that (putting scripts in different files, indentation, etc) so I cannot merge as-is.

Try to extract that specific feature (copy & paste) so the changeset is readable and contained so I can review it

thanks !

— Reply to this email directly, view it on GitHub https://github.com/tchapi/Adafruit-GFX-Font-Customiser/pull/33#issuecomment-1024907194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ3UKSBLJ3NFZPJ7QTTHSDUYPQDFANCNFSM5NCQNRMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

m4xr1sk commented 2 years ago

I have reverted the changes then added just the few lines to do the copy and paste. Now the 2 branches are comparable.