Update index.html - Githubissues

tchapi / Adafruit-GFX-Font-Customiser

A little utility to customise pixel fonts for the Adafruit GFX library

https://tchapi.github.io/Adafruit-GFX-Font-Customiser/

MIT License

90 stars 47 forks source link

Update index.html #6

Closed thelevelofdetail closed 5 years ago

thelevelofdetail commented 5 years ago

changed updatePixels and export to use data-pixels attribute instead of reading values from dom elements This should fix some issues with negative xoffsets and data width > width

tchapi commented 5 years ago

Hi @thelevelofdetail and thanks a lot for this PR.

It looks good to me;

Could you fix the style (trailing semi colons, indentation, braces for one-line ifs, unicode characters, etc) and add a test font file (the FreeMonoBold12pt7b you were talking about and that was having problems) so that I can merge this commit ?

Thanks a lot !

thelevelofdetail commented 5 years ago

Hey @tchapi i hope i fixed all style issues. After switching from Notepad++ to VSCode those unicode characters seem to work now as well.

tchapi commented 5 years ago

Great, I'll merge that soon