Refactor v0 - Githubissues

tcharding / rust-psbt

Partially Signed Bitcoin Transactions

Creative Commons Zero v1.0 Universal

13 stars 6 forks source link

Refactor v0 #7

Closed tcharding closed 10 months ago

tcharding commented 10 months ago

Do two refactorings:

Move base64 stuff to v0 module
Refactor v0::raw module

DanGould commented 10 months ago

Why is base64 moving into v0? Won't it be much the same for other versions as long as raw for each module is somewhat independent?

tcharding commented 10 months ago

Quite possibly, I'm using the method of moving everything to v0 then de-duplicating in the best way later on.

EDIT: I took another look, I remember exactly why I did this now. I was not 100% sure if v2 and v0 were supposed to be displayed the same so I moved the base64 stuff to be safe. (I have not fully absorbed bip-370 yet.)