tchayen / markdown-links

Command that displays a graph of local links between markdown files
MIT License
246 stars 53 forks source link

Error report from VS Code extension monitor - perhaps the source of the large graph performance issue? #49

Open nixsee opened 4 years ago

nixsee commented 4 years ago

:warning: We have written the needed data into your clipboard. Please paste! :warning:

{
    "messages": [],
    "activationTimes": {
        "codeLoadingTime": 12,
        "activateCallTime": 0,
        "activateResolvedTime": 1,
        "activationReason": {
            "startup": false,
            "extensionId": {
                "value": "tchayen.markdown-links",
                "_lower": "tchayen.markdown-links"
            },
            "activationEvent": "onLanguage:markdown"
        }
    },
    "runtimeErrors": [
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        },
        {
            "name": "Error",
            "message": "Webview is disposed"
        }
    ]
}
ianjsikes commented 4 years ago

I've run into this as well. I don't think its a performance thing, but in my experience it just causes the graph to completely break. I think the extension needs to listen for panel.onDidDispose() and do something smart. No clue what causes the panel to dispose though.

tchayen commented 4 years ago

Hm, listening to onDispose is one thing, but what to do with that is another. Should it be immediately reopen? Should we assume that disposed webview means that the tab closed in the editor?

I feel like any information that moves us in a proper direction is needed before handling that.