Remove extraneous params from subsequent query requests

tchellomello / python-arlo

Python Arlo is a library written in Python 2.7/3x that exposes the Netgear Arlo cameras as Python objects.

GNU Lesser General Public License v3.0

100 stars 35 forks source link

Remove extraneous params from subsequent query requests #101

Closed lukiffer closed 6 years ago

lukiffer commented 6 years ago

Prevents username and password params from being included on each request.
Explicitly includes them on authentication requests.

coveralls commented 6 years ago

Coverage decreased (-0.02%) to 79.846% when pulling 8c4cebcd1a9c35b36d894e3b63519a521abe64b5 on lukiffer:extra-params-fix into 2cf24020671a52504719277715b39863ab3323b3 on tchellomello:master.

lukiffer commented 6 years ago

This should fix #100. I've got it running in my Home Assistant instance and it has fixed the issue for me. That said I only have the Arlo Baby to test with - anyone else able to test out this fix would be greatly appreciated.

pschmitt commented 6 years ago

Working fine here for my 3x Arlo Pro 2 and the base station. The modes are retrieved correctly. LGTM.

lukiffer commented 6 years ago

@tchellomello based on the feedback here and on https://github.com/home-assistant/home-assistant/issues/17427 this appears to fix the issue without negative side effects. Can I get a code review and a bump/publish to PyPi?