search

tchlyah / couchmove

Java data migration tool for Couchbase
Apache License 2.0
39 stars 14 forks source link

🐛#12 Fix missing FTS parameters #13

Closed gkysaad closed 3 years ago

gkysaad commented 3 years ago

Implemented a fix for this issue: https://github.com/differentway/couchmove/issues/12

I added a CustomSearchIndex (extension of Couchbase SearchIndex class) in order to override the toJson() function so that custom parameters can be used for the creation of an FTS index.

tchlyah commented 3 years ago

Hello, thanks for your help on the issue.

Can you add some tests proving that it is actually fixing the issue, it will also help to avoid a future regression ?

gkysaad commented 3 years ago

Hello, thanks for your help on the issue.

Can you add some tests proving that it is actually fixing the issue, it will also help to avoid a future regression ?

No problem! I've added some code to test for the custom params specified in the integration tests.

gkysaad commented 3 years ago

Can you also rebase your branch with master as I pushed a fix for failing tests ?

There was an issue with rebasing on Git due to files containing :: in the name (user::titi.json and user::toto.json), causing Git to throw an error for me, so I manually put in the changes from your latest commit. I also updated the version in the gradle.properties file to 3.2.

tchlyah commented 3 years ago

Can you also rebase your branch with master as I pushed a fix for failing tests ?

There was an issue with rebasing on Git due to files containing :: in the name (user::titi.json and user::toto.json), causing Git to throw an error for me, so I manually put in the changes from your latest commit.

Windows joy 🤩 ! I’ll rename those files to avoid such issues.

I also updated the version in the gradle.properties file to 3.2.

It’s a bug fix and not a new feature, the new version should be 3.1.1. Anyway the version is dynamically set on the release, but it’ll impact SNAPSHOT versions.

I’ll release a SNAPSHOT version tomorrow morning for you to test that everything is good before release a final version.

gkysaad commented 3 years ago

Awesome, thanks for your help!