search

tchvu3 / capacitor-voice-recorder

Capacitor plugin for voice recording
69 stars 57 forks source link

Request: Update example & code to capacitor 3.0 syntax #7

Closed qpwo closed 3 years ago

qpwo commented 3 years ago

Details of differences here: https://capacitorjs.com/docs/updating/3-0

inexuscore commented 3 years ago

Is this repository actively maintained? I was excited to get started with this but it doesn't work on Capacitor 3.

Error: node_modules/@capacitor/core/types/definitions-internal.d.ts:16:18 - error TS2430: Interface 'CapacitorInstance' incorrectly extends interface 'CapacitorGlobal'. Types of property 'Plugins' are incompatible.  

Property 'VoiceRecorder' is missing in type '{ [pluginName: string]: { [prop: string]: any; }; }' but required in type 'PluginRegistry'. export interface CapacitorInstance extends CapacitorGlobal {
tchvu3 commented 3 years ago

As I made this plugin primarily for my own use case I could not find the time to add additional features (as requested by some people). with that said, I'm about to update my project to ver 3 of Capacitor and so I will updated this plugin in the coming days

inexuscore commented 3 years ago

@tchvu3 Fantastic, thank you. Ionic+Capacitor is great but it's a shame that there aren't official plugins for the essentials.

tchvu3 commented 3 years ago

The plugin has been updated to capacitor v3. though I didn't have time to test it thoroughly. so if you had a chance to drop a comment after you try it please let me know if you had any problem.