search

tchwork / utf8

Portable and performant UTF-8, Unicode and Grapheme Clusters for PHP
Apache License 2.0
627 stars 50 forks source link

Add php8 as CI target #77

Closed ChristophWurst closed 3 years ago

ChristophWurst commented 3 years ago

We might have to also adjust the distro as precise is a bit outdated but let's see

Once I know the tests indeed fail I'll tackle https://github.com/tchwork/utf8/issues/74

ChristophWurst commented 3 years ago

FYI Travis is kind of shutting down. I suggest moving to Github Actions. If you need help please let me know :v:

ChristophWurst commented 3 years ago

I hopefully migrated to travis-ci.com, lets see how it goes.

don't get your hopes up. they limit the "open source credit" that you get. and while the docs say you can get credit for open source, they actually shut that program down. so either you pay or you have to use something else. it's affecting us a lot at Nextcloud and they did that without any warning. just as a heads-up.

ChristophWurst commented 3 years ago

Ok, so this runs but it doesn't pass. but I see other builds did just fail as much: https://travis-ci.org/github/tchwork/utf8/builds/752168267. @nicolas-grekas do you have any idea for how to support such a wide range of php versions with phpunit?

Some new failures include 

1) Patchwork\Tests\PHP\Shim\IntlTest::testGrapheme_substr

Failed asserting that '' is identical to false.

/home/travis/build/tchwork/utf8/tests/PHP/Shim/IntlTest.php:89

2) Patchwork\Tests\PHP\Shim\IntlTest::testGrapheme_strpos

Failed asserting that 0 is identical to false.

/home/travis/build/tchwork/utf8/tests/PHP/Shim/IntlTest.php:122

3) Patchwork\Tests\PHP\Shim\MbstringTest::testmb_stubs

mb_encode_mimeheader() is bugged. Please use iconv_mime_encode() instead

Failed asserting that true is false.

/home/travis/build/tchwork/utf8/tests/PHP/Shim/MbstringTest.php:31

4) Patchwork\Tests\PHP\Shim\MbstringTest::testmb_strpos

Failed asserting that 0 is identical to false.

/home/travis/build/tchwork/utf8/tests/PHP/Shim/MbstringTest.php:113

5) Patchwork\Tests\PHP\Shim\MbstringTest::testmb_strpos_empty_delimiter

The previous line should trigger a warning (Empty delimiter)

Failed asserting that true is false.

/home/travis/build/tchwork/utf8/tests/PHP/Shim/MbstringTest.php:148
nicolas-grekas commented 3 years ago

Honest question: are you really using this package? Why not https://github.com/symfony/polyfill-mbstring/ and the likes instead?

ChristophWurst commented 3 years ago

Well this is embarrassing for me. I checked in detail and while we still depend on this package, another package recently also added the intl-normalizer polyfill from Symfony into our project and so if I disable the intl extension I actually get a conflict because this package tries to re-declare a already polyfilled function.

Hence we can close this as we indeed won't use the package anymore once my change removes it from our project.

Thanks, in any case and cheers from Nextcloud :v: