tchx84 / Flatseal

Manage Flatpak permissions
GNU General Public License v3.0
1.21k stars 72 forks source link

Search permissions #125

Closed tchx84 closed 1 year ago

tchx84 commented 4 years ago

Taken from a comment in Flatseal gnome-software page

Only thing missing is a permission search feature

Flatseal currently supports 30 different permissions. Maybe something like this could be of help.

@bertob by any chance, do you know of other examples were search is implemented among settings / options? So I can based this on.

bertob commented 4 years ago

Libhandy's HdyPreferencesWindow search is probably a good example to look at

tchx84 commented 3 years ago

@YaLTeR please feel free to describe your design there :)

YaLTeR commented 3 years ago

So my issue is that:

I initially proposed focusing the app search entry by default on launch, however on mobile this brings up the OSK which is awkward.

Therefore my idea is to add an initial empty state with no app selected (currently on launch the first app is selected). When typing on the empty state it will type to search for the app, and when typing on an app permissions page it will type to search for the permissions.

tchx84 commented 3 years ago

Therefore my idea is to add an initial empty state with no app selected (currently on launch the first app is selected). When typing on the empty state it will type to search for the app, and when typing on an app permissions page it will type to search for the permissions.

The difficulty I see is that both, the app list and permissions list, "exist" in the exact same place. I am no designer, but wouldn't this feel a bit weird? I mean, to have the exact same action (typing) behaving differently in the exact the same place (the same view/window)?

bertob commented 3 years ago

I'd take a step back here and figure out what use cases wer're trying to address here first. Is it about searching for a specific permission within the page of an app? Or searching for the value of the same permission across all apps? Something else?

tchx84 commented 3 years ago

I'd take a step back here and figure out what use cases wer're trying to address here first. Is it about searching for a specific permission within the page of an app? Or searching for the value of the same permission across all apps? Something else?

good point, I am assuming the first case (within the page of the currently selected app).

bertob commented 3 years ago

In that case a second search button/bar in the content pane would be the most obvious solution, no?

tchx84 commented 3 years ago

In that case a second search button/bar in the content pane would be the most obvious solution, no?

This would work for mobile fine but, honest question, for the desktop, wouldn't be confusing to have two search buttons on the same header bar ?

I am quite pragmatic, so if you think that doesn't break some sacred design vow, I wouldn't mind* hah

bertob commented 3 years ago

Maybe we could use a different icon (e.g. a funnel for "filter") for the in-panel one?

tchx84 commented 3 years ago

Maybe we could use a different icon (e.g. a funnel for "filter") for the in-panel one?

sure, let's try it.

Arxcis commented 3 years ago

@tchx84 Did you consider reusing this search-bar design from gnome-settings?

Gnome-settings on Pop!OS 20.10 didyouconsider

Obviously, the root-level would be "Applications" instead of "Settings", and when clicking on an app, you would get search within the selected application.

From Flatseal. Very similar design already. image

I think this issue is very related to #166 , and there is a potential to solve 2 issues at the same time here.

tchx84 commented 1 year ago

It's unlikely that I be working on this anytime soon, if someone feels like designing this, please re-open.

hyuri commented 1 year ago

Here's a quick design. One for searching apps that have a particular permission ("network", in this example), and one for searching a permission ("pulseaudio", in this example) within a selected app (Blender, in this example).

Flatseal Search Permissions Design (pixelated for security)

Clicking the "filter" icon + "Permission" text, in the apps search, gives you the other filtering options.

Default is "App Name".

The two search bars are independent and unrelated, basically.

Note: The search results are not shown in the picture, as you can see. This was just a quick mock up. But I'm sure you know what's supposed to show up as results of both search queries:

  1. In the "Applications" search (on the left), having the filter set as "Permission" and searching for a given permission — such as "network", in the pictured example — results in a list of all the apps that have that permission activated;
  2. In the "Application Permission" search (on the right), searching for a given permission causes the selected app page to only display the section(s) containing the query.
DominiqueSite commented 3 months ago

It would be really useful to be able to filter all apps for specific permissions (e.g. network access)! Any chance that this (slightly different from searching inside an app page) feature might be implemented now that there's a design suggestion @tchx84?