search

tchx84 / Flatseal

Manage Flatpak permissions
GNU General Public License v3.0
1.21k stars 72 forks source link

Split headerbar #18

Closed bertob closed 4 years ago

bertob commented 4 years ago

The non-split headerbar is a bit odd, since it mixes gobal controls (primary menu) and ones specific to the currently selected app (title, reset button).

image

I'd change it to what e.g. Disks and Settings do, a split headerbar and the primary menu on the right side of the left panel. This would also make it easier to make the app adaptive with HdyLeaflet later, since you could cleanly split the two panels.

image

tchx84 commented 4 years ago

Yes, in fact, the current "design" is inspired in GNOME settings applications section, which does exactly what you describe.

I just haven't got into it, since I have been prioritizing other things.

tchx84 commented 4 years ago

I will give it a try today.

tchx84 commented 4 years ago

This is an initial pass, I just need to check gnome-disks code and see how it does to "sync" both panes.

Screenshot from 2020-02-06 10-55-43

bertob commented 4 years ago

Looks great! I'd maybe use the app name as the title on the left panel.

tchx84 commented 4 years ago

I ended up implementing this with libhandy, behaves pretty decently.