search

tchx84 / Portfolio

A minimalist file manager for those who want to use Linux mobile devices.
GNU General Public License v3.0
93 stars 23 forks source link

window: follow GNOME dark style preference changes #272

Closed pabloyoyoista closed 1 year ago

pabloyoyoista commented 1 year ago

Use libhandy's StyleManager to follow the dark mode variant used by libadwaita and GTK4 apps through gsettings org.gnome.desktop.interface.color-scheme key. This allows the app to change its style based on a standard and documented property that can be changed through, e.g: GNOME Settings toggle in Appearance panel. Current behavior is to follow the gtk-application-prefer-dark-theme key in ~/.config/gtk-3.0/settings.ini file, which is deprecated and as far as I am aware, undocumented.

Related https://gitlab.gnome.org/GNOME/Initiatives/-/issues/32

pabloyoyoista commented 1 year ago

I just realized #19 I guess this might be a possible solution to that problem?

tchx84 commented 1 year ago

Thanks @pabloyoyoista , there's a few missing changes to land this but ill do this on a separate branch.

tchx84 commented 1 year ago

https://github.com/tchx84/Portfolio/pull/274

pabloyoyoista commented 1 year ago

Thanks a lot for taking care of it! To be fair, I had just forgotten about this...