minhchau273
commented
8 years ago :+1: Nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.
This was a challenging assignment, congrats on completing it successfully!
Grading Summary:
- Functionality: Good
- Code Style: Good
- Visual Design: Average
Overall: Good
Detailed Notes
- Nice work specifying the Auto Layout constraints.
- Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.
- Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.
- Good job with the infinite scrolling.
- That would be nice is if you handled the "no results" case gracefully, as well as didn't show empty gray lines when there is only 1 result.
- It would be better if you save the last user's choices in the filters page.
- It's a little bit weird when I search with no results, then I pull to refresh and the results appear and of course, they're not the right results. After I try to search with that keyword many times, your app crashes. Please view the GIF file below.
Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work. 🍡
tcltien
/cc @coderschoolreview