search

tcmxx / UnityTensorflowKeras

Unity In Editor Deep Learning Tools. Using KerasSharp, TensorflowSharp, Unity MLAgent. In-Editor training and no python needed.
Other
52 stars 15 forks source link

Add Conv1D #2

Closed BrendanMulcahy closed 5 years ago

BrendanMulcahy commented 5 years ago

Conv1D is left unimplemented (presumably because it was not added in the original TFSharp repo). How difficult would this be to add to your TFSharp/KerasSharp/Unity repos?

I could try to do the work and submit a PR. I'm interested in trying to do a temporal convolutional network (TCN) in place of an RNN.

Thoughts?

tcmxx commented 5 years ago

It should not be too hard to add conv1D. We use a fork of KerasSharp as the backend and because that repo is stopped so Conv1D is not implemented. The implementation should be similar to the conv2D implementation here:https://github.com/tcmxx/keras-sharp/blob/master/Sources/Layers/Convolutional/Conv2D.cs.