just release without files

tcnksm / ghr

Upload multiple artifacts to GitHub Release in parallel

http://tcnksm.github.io/ghr/

MIT License

1.23k stars 80 forks source link

just release without files #118

Closed roschaefer closed 5 years ago

roschaefer commented 5 years ago

fix #111

Todo

[ ] Decide if we want to make PATH part of the options. That would be simpler but would also break the current API as you have to put the options in front of TAG.

roschaefer commented 5 years ago

@tcnksm @Songmu Travis CI is missing $GITHUB_TOKEN, isn't it?

Songmu commented 5 years ago

Thanks. I'll merge it.

On TravisCI the encrypted environment variables are not available for pull requests from forks due to security risks.

Please note that encrypted environment variables are not available for pull requests from forks. https://docs.travis-ci.com/user/encryption-keys/

As a result, the tests on pull request always fails. We recognize this as a problem.

roschaefer commented 5 years ago

OK, cool! What about creating a separate Github account which has permissions for just one repository and publish that token? That would be an alternative for #116 you could simply check $GITHUB_TOKEN into source code and we would keep the hard-coded TestRepo and TestOwner configurations.

roschaefer commented 5 years ago

Hm, I guess publishing a $GITHUB_TOKEN would also enable people to create new repositories with that token? Maybe not the best idea.

Songmu commented 5 years ago

Released as v0.13.0.