tcobbs / ldview

Real-time 3D viewer for displaying LDraw models
https://tcobbs.github.io/ldview/
GNU General Public License v2.0
87 stars 17 forks source link

Win: treat build error C3861: '_mkgmtime': identifier not found #87

Closed trevorsandy closed 3 weeks ago

trevorsandy commented 3 weeks ago

Hi Travis & Peter,

I encountered this Windows build break some weeks ago and noticed that when attempting to build a clean pull of LDView master, the break is still present.

LDView_Build_C3861_Error

Cheers,

pbartfai commented 3 weeks ago

I managed to build Debug Win32 code on VS2022 without this error. Which version of Visual Studio / Platform SDK do you use? I have VS2022 (17.11.4) with Windows 10 SDK (10.0.19041.0)

trevorsandy commented 3 weeks ago

On VS2022 (17.11.4) I'm using Windows 11 SDK (10.0.22621.0) and Windows 10 SDK (10.0.20348.0).

For the Win32 builds, I'm also using MSVC v141 - VS 2017 and MSVC v140 - VS 2015 to support the version of the pre-compiled libraries provided with LDView.

LDView_Build_VS_Components

Cheers,

tcobbs commented 3 weeks ago

I don't fully understand why this builds for us, but the change doesn't appear to hurt anything.