Closed dewski closed 12 years ago
Working on it. I think I am going to move the master branch to a rails2.3.x branch, then promote the rails3 branch to master. I'll then start working on getting it into gem form with Jeweler.
Any idea what the bast way to make the switch is with the branches in git?
I was actually just considering doing this so I could manage this dependency with bundler for my rails 3 project. I would suggest you use bundler not jeweler for turning it into a gem, and I'd probably be willing to do the work if you want to merge upsteam. I'm not too familiar with how plugin dependencies can be managed other than git submodules, but I'd suggest just creating a rails-2-3 stable git branch is all. You should be able to specify a git branch when installing the plugin by passing the -r option:
script/plugin install git://github.com/tcocca/acts_as_follower.git -r rails-2-3
Plugin from git branch source: http://www.themomorohoax.com/2009/03/24/install-rails-plugin-from-git-repo-with-branch
+1 on using bundler not jeweler. Really don't need all the cruft. I'm happy to fork and send you a pull.
@james2m if you want to send a pull with a gemified version I would greatly accept. I agree with straight bundler instead of jeweler. Just havent found the time to do this yet.
~ tom
Any objections to me dropping a rails3 test environment in the test folder to make the test suite self contained?
J.
no objections, It would be nice to have something to test rails 3 and rails 3.1
not sure if it works with 3.1, haven't tried it yet
Are you planning on using something like combustion ? ( https://github.com/freelancing-god/combustion ).
I was actually just thinking about converting this thing to an engine
I hadn't seen combustion before. I was going the simple route of putting just enough of rails3.0 into the test suite in a similar way to josevalim/enginex but a bit more stripped back as we really only need activerecord and railties to work. This way would be easy enough to add a rails3.1 environment too.
Actually I'm going to be using it in a 3.1 app.
I'm not a big fan of engines personally, that said all the functionality here is very self contained so it may be the logical next step.
Sounds good, I say maybe just the gem version and the rails 3 test for now, unless you want to go for a rails 3.1 test setup too? If you aren't up for this thats fine too.
I've just sent a pull request with the gemification. I tested on 3.1 and 3.0 but haven't made them configurable without hacking the Gemfile.
would love a gem update for the latest updates. Fixed some issues for me related to mass assignment
I'll get a new version out this weekend, hopefully tomorrow.
I think this was what I was working on: https://github.com/tcocca/acts_as_follower/pull/17 See the comments regarding the includes hash. Not sure what to do there for now..
~ Tom
@aaronchi just released a 0.1.1 version.
Is there any plan to release a gem for this so we don't have to install it as a plugin?