tconbeer / harlequin

The SQL IDE for Your Terminal.
https://harlequin.sh
MIT License
3.37k stars 75 forks source link

fix #485: avoid crash due to duplicate screen id #486

Closed zqianem closed 3 months ago

zqianem commented 3 months ago

Closes #485

What are the key elements of this solution?

This fix takes option (a) from the issue and maps the F8 key to nothing once the history screen is open.

Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs?

An alternative is to bind F8 to the cancel action or nothing in the history screen class, but that makes it awkward as the F8 binding would be then defined in two places.

Does this PR require a change to Harlequin's docs?

Did you add or update tests for this change?

Please complete the following checklist: