Add ADBC Adapter - Githubissues

TylerHillery commented 3 months ago

No open issue by does relate to #383 (I didn't want to mark it as "resolves" as it's not technically a Snowflake specific adapter so I will leave that up to you to decide)

What are the key elements of this solution? Adds adbc adapter as an extra

Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs? Followed typical PR format for adding an adapter as an extra

Does this PR require a change to Harlequin's docs?

[ ] No.
[ ] Yes, and I have opened a PR at tconbeer/harlequin-web.
[x] Yes; I haven't opened a PR, but the gist of the change is: Need to add ADBC adapter docs

Did you add or update tests for this change?

[ ] Yes.
[x] No, I believe tests aren't necessary.
[ ] No, I need help with testing this change.

Please complete the following checklist:

[x] I have added an entry to CHANGELOG.md, under the [Unreleased] section heading. That entry references the issue closed by this PR.
[x] I acknowledge Harlequin's MIT license. I do not own my contribution.

TylerHillery commented 3 months ago

Not quite sure what I am doing wrong, I updated pyproject.toml then ran poetry lock

tconbeer commented 3 months ago

Looks like Numpy 2.0 was released and is causing all kinds of issues -- we may have to pin one or more dependencies to 1.X. I can try to work through it this week.

tconbeer commented 3 months ago

superseded by #519

tconbeer / harlequin

Add ADBC Adapter #517