What are the key elements of this solution?
This adds a new optional property and method for adapters; if that method is implemented, it displays a button in the run query bar to toggle the transaction mode.
Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs?
Adding methods, instead of class vars, made it easier to implement this and maintain backwards compatibility.
Does this PR require a change to Harlequin's docs?
[x] Yes; I haven't opened a PR, but the gist of the change is: Should document the transaction behavior for sqlite; should update the adapter guide to explain new prop and method on the connection.
Did you add or update tests for this change?
[x] Yes.
[ ] No, I believe tests aren't necessary.
[ ] No, I need help with testing this change.
Please complete the following checklist:
[x] I have added an entry to CHANGELOG.md, under the [Unreleased] section heading. That entry references the issue closed by this PR.
[x] I acknowledge Harlequin's MIT license. I do not own my contribution.
closes #334
What are the key elements of this solution? This adds a new optional property and method for adapters; if that method is implemented, it displays a button in the run query bar to toggle the transaction mode.
Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs? Adding methods, instead of class vars, made it easier to implement this and maintain backwards compatibility.
Does this PR require a change to Harlequin's docs?
Did you add or update tests for this change?
Please complete the following checklist:
CHANGELOG.md
, under the[Unreleased]
section heading. That entry references the issue closed by this PR.