Open michael-the1 opened 1 month ago
Thank you for this! I'm mostly away from my computer this week but I'll try to review next week.
@michael-the1 Sorry I dropped the ball on this. I'd love to get this finalized. Looks like there are quite a few failing tests and lints. Do you want to work through those? Let me know if you get stuck.
@tconbeer Life can get busy which I totally understand.
The reason the tests are failing is because mistletoe
is not installed in the test workflows. Should I add it to the dev
or test
group in pyproject.toml
? Feels a bit... not neat 😅
Closes https://github.com/tconbeer/sqlfmt/issues/593
There are two caveats that would be good to consider:
mistletoe
keeps all the important whitespace, but can toss out some unnecessary whitespace, such as trailing whitespace or double newlines. A good example is in theREADME.md
of this very repo:I think this is acceptable since it does not affect readability and should not affect output (i.e. when it's rendered to HTML).
sql
blocks are not formatted. I think this is acceptable. See example: