Use MaxRect algorithm to pack textures; add dropdown to atlas preview window to see changes

tconkling / flump

Exports Flash .FLAs to GPU-friendly formats

MIT License

381 stars 70 forks source link

Use MaxRect algorithm to pack textures; add dropdown to atlas preview window to see changes #135

Closed matyasatfp closed 9 years ago

matyasatfp commented 9 years ago

Same as my previous PR, just in one commit

tconkling commented 9 years ago

Cool. I will take a look at this in the next few days, and run it against my own project.

@roguenet and @aduros, do you guys also want to take a look?

tconkling commented 9 years ago

(Whoops, I closed the wrong pull request)

roguenet commented 9 years ago

Yeah, I'll take a look and see about running it against the MM project files - I'm interested to see if this algorithm takes care of the ridiculous slowness on our level files we saw with the old one.

On Tue, Jan 13, 2015 at 5:44 PM, Tim Conkling notifications@github.com wrote:

(Whoops, I closed the wrong pull request)

— Reply to this email directly or view it on GitHub https://github.com/threerings/flump/pull/135#issuecomment-69856075.

Nathan Curtis

aduros commented 9 years ago

I don't think I'll have time to try it out this week, so feel free to merge.

matyasatfp commented 9 years ago

Are you planning to review/merge this? Or is Flump abandoned? I think I'll need to make other improvements. So now I either care about my fork only or face big headaches because of pull request merge conflicts.

tconkling commented 9 years ago

Sorry for the late response, matyasaftp. I've been head-down on my game and have been neglecting your pull request. Checking it out now!

matyasf commented 9 years ago

No problem, in the meanwhile ive made improvements in my own branch. The 2 main ones are:

Much faster instantiation (parsing a flump .zip is around 2x faster and instantiating a parsed movie is around 9x faster)
Assets are exported based on the maximum size you use them. Thus artists can scale them however they want and they wont look pixelated or take up unneccesary space.

This PR has a bug, you can see the fix in https://github.com/funkypandagame/flump/commit/407b8e4a434c05c3f46c81b51f77e662e61b66d8 MaxRectMultiPacker.as. I suggest if you merge then make another commit with these changes.

tconkling commented 9 years ago

I rebased your commits rather than merging them (which, in hindsight, was probably the wrong thing to do as Github does not know that these commits are part of mainline).

Thanks again!

markknol commented 9 years ago

@matyasf That also means that you cannot optimized assets? for example, we use a lot of 10x10px sprites that get stretched to fill backgrounds for example. How to deal with that? Also for animated particle effects we use smaller assets which get scaled bigger to have better performance. It's very nice to be in control which stuff gets scaled and which not. Our artist can perfectly deal with this scaling behavior, when they get instructed to keep it in mind. I hope this gets implemented as a setting.

tconkling commented 9 years ago

@matyasatfp I'd definitely be interested in merging your movie instantiation optimizations. I share @markknol's trepidations about the auto-scaling behavior, which I think would only work as an optional setting.

tconkling commented 9 years ago

Also: @matyasatfp, I'm pulling your bugfix from 407b8e4a434c05c3f46c81b51f77e662e61b66d8, though the only way I can do this cleanly is with a cherry-pick commit, which means that our repos will be diverging again. If you want to submit more pull requests, it probably makes sense to rebase them onto a new clean branch off threerings flump/master