search

tcoopman / elm-css-webpack-loader

34 stars 13 forks source link

Upgrade v0.17 #3

Closed matiasfha closed 8 years ago

matiasfha commented 8 years ago

Now the loader works with elm 0.17 Still need work to make this work with https://github.com/webpack/extract-text-webpack-plugin

tcoopman commented 8 years ago

I'm very busy at the moment, but I'll try to take a look at it soon. Can you check why the tests fail, and see if you can fix them?

tolgap commented 8 years ago

@msdark You seem to have forgotten to up the ELM_VERSION variable inside .travis.yml. :)

matiasfha commented 8 years ago

I update the pr code but need to run the travis-ci build again..

stkb commented 8 years ago

Two files have been added (maybe by mistake?): /elm-package.json and /test/elm-package.json. I don't think they're needed.

elm-css v0.5.0 doesn't support node 0.12 any more so that needs taking out of the test matrix in .travis.yml.

Also the timeout for the async-mode test in loader.js needs bumping up even further to maybe 1000s. I tried making these changes in my own fork and Travis was all green after that.

tcoopman commented 8 years ago

@msdark Thanks!

tcoopman commented 8 years ago

released as 2.0.0