tcopeland / pippi

pippi
287 stars 12 forks source link

pippi 0.0.11 causing numerous rspec failures #26

Closed dankohn closed 9 years ago

dankohn commented 9 years ago

I've been using pippi 0.0.6 with no problems, but 0.0.11 is causing numerous RSpec failures. Frustratingly, the error is only on my CircleCI server (running Ubuntu), but not on my OS X dev machine, making it hard to diagnose the problem. It appears, though, that pippi is grabbing tons of memory when CircleCI has a 4 GB limit. I have:

# spec/spec_helper.rb
if ENV['USE_PIPPI'].present?
  require 'pippi'
  Pippi::AutoRunner.new(checkset: ENV['PIPPI_CHECKSET'] || 'basic')
end

I'm invoking RSpec with:

USE_PIPPI=1 bundle exec rspec --color --require spec_helper --format documentation spec
tcopeland commented 9 years ago

@dankohn hmmm interesting, I'm not seeing spec failures locally, but I can imagine that it uses tons of memory on large codebases, since it adds singleton methods to many objects. I'm not sure if there's much that we can do about it, though.

dankohn commented 9 years ago

That's fine. I'll just run it intermittently on my dev machine rather than including it in our continuous integration test runs.

Dan Kohn mailto:dan@dankohn.com tel:+1-415-233-1000

On Thu, Jan 22, 2015 at 12:38 PM, Tom Copeland notifications@github.com wrote:

@dankohn https://github.com/dankohn hmmm interesting, I'm not seeing spec failures locally, but I can imagine that it uses tons of memory on large codebases, since it adds singleton methods to many objects. I'm not sure if there's much that we can do about it, though.

— Reply to this email directly or view it on GitHub https://github.com/tcopeland/pippi/issues/26#issuecomment-71062379.

tcopeland commented 9 years ago

Cool ok.