tcorreabr / Parachute

Look at your windows and desktops from above.
GNU General Public License v3.0
356 stars 32 forks source link

Add optional shortcuts for opening and closing parachute #113

Open BananaLoaf opened 3 years ago

BananaLoaf commented 3 years ago

I use touchegg for touchpad gestures and I have assigned three finger swipe up and three finger swipe down for toggling parachute. The problem is that both gestures do the same thing and swiping up/down to open and then swiping the same direction to close does not feel natural. Moreover, due to touchegg nature, swiping up half way would open parachute and swiping up the rest of the way would close it and I think that delegated shortcuts for opening/closing would solve that issue. I humbly ask you to implement said feature.

koma111 commented 3 years ago

I think the best way to do this would be to have separate shortcuts indeed, but set the same combination for both by default, and tell the user in README, to set both to the same key combo to make it work as a toggle.

KINGSABRI commented 3 years ago

The toggle behavior makes sense (one press opens, same press closes)

koma111 commented 3 years ago

The toggle behavior makes sense (one press opens, same press closes)

Yes, on desktop, it does. But that can be replicated by having separate shortcuts for opening and closing, and by default setting them to THE SAME KEY COMBO. This way, users who want the default toggle behavior suspect nothing, but laptop/touchpad users, who want to use touchpad gestures, can bind them to the two different actions. Having the cake and eating it too.

KINGSABRI commented 3 years ago

Oh, totally agreed. I didn't think about the mouse-pad gesture. it would be really cool to match macOS gesture