search

tcorreabr / mouse-swipe

Swipe gestures support for mouse buttons
GNU General Public License v3.0
32 stars 6 forks source link

Diagonal mouse gestures, #4

Open avnibilgin opened 8 months ago

avnibilgin commented 8 months ago

Hello dear developers,

If you would implement diagonal 4 diagonal mouse movements, the app would be even better. swipe_up_right, swipe_down_right, swipe_up_left, swipe_down_left, for example.

tcorreabr commented 8 months ago

I don't have time to dedicate to this project at the moment. But I can merge it if someone makes a PR with this improvement.

avnibilgin commented 8 months ago

Hello, thanks for the answer,

I'm not a programmer and have a bit of a superficial basic knowledge of Python.

I tried to revise the async def task_handle_mouse_events(mouse) in the main.py to capture diagonal mouse movements but unfortunately I couldn't do it. As far as I know so far, your application is the only Wayland mouse gesture application that works smoothly, is very clear, concise, minimalistic and efficiently programmed. All other applications that I have tried as an alternative have defects, so that they are practically unusable in daily work.

So thanks again to her.

JuBan1 commented 8 months ago

Hey @avnibilgin,

if you'd like you can try my fork.

I includes directional swipes like swipe_up_right and multi-swipe gestures, such as swipe_left, swipe_right. You can see some in the test config file.

If the gesture recognition isn't responsive enough you can try lowering to granularity of the gesture recognizer.

While it seems to work reasonably well, it's very much a Work-In-Progress and might have bugs or broken functionality. I don't actually know how to code Python, but I test-covered most of the things I've done.

I want to eventually finish it and maybe even submit it here upstream, although basically turned out to be a near complete rewrite of everything so I'm not sure how appreciated or helpful it would be :thinking:

avnibilgin commented 8 months ago

Hi @JuBan1,

you are simply amazing! Thanks! I installed and tested it and it works smoothly on my Arch Linux Hyprland. To my knowledge and previous knowledge, this is the first independent app that takes over diagonal movements on Wayland "without restrictions". Before that, I tested some other applications where, for example, the right button is overridden when gesture mode is activated, etc. So this well-functioning solution is unique at the moment. I can't say anything about whether you want to keep it as a standalone app yourself or submit it here. I'm not familiar with this matter of forks etc. But what is certain is that from now on I will continue to use your application/fork, which is a very good and completely usable solution for me. Good job !!! Thanks again. But if you want to advertise it as a fork on the internet, then I would ask you to adjust the installation data and the installation process so that the correct src files are copied into the correct folders. Because at the moment, according to the install file, the original files are copied into it and not your newly created/programmed fork-specific files (similarly with the config file etc)