tcort / markdown-link-check

checks all of the hyperlinks in a markdown text to determine if they are alive or dead
ISC License
559 stars 116 forks source link

(node:1) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. With Docker #314

Open valorisa opened 2 months ago

valorisa commented 2 months ago

Hello,

By using Docker from macOS Sonoma, I obtain the following message :

% docker run --rm --name markdown-link-check --platform linux/amd64 -v ${PWD}:/Projets/markdownlint/:ro -i ghcr.io/tcort/markdown-link-check:3.12.1 CONTRIBUTING.md README.md
(node:1) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

FILE: CONTRIBUTING.md
  No hyperlinks found!

  0 links checked.

FILE: README.md
  [✓] https://www.npmjs.com/package/isemail
  [✓] https://github.com/gaurav-nelson/github-action-markdown-link-check
  [✓] https://pre-commit.com
  [✓] https://megalinter.io/latest/
  [✓] https://megalinter.io/latest/descriptors/markdown_markdown_link_check/
  [✓] https://www.npmjs.com/package/ms
  [✓] https://github.com/tcort/markdown-link-check/issues/78
  [✓] https://github.com/tcort/markdown-link-check/blob/master/LICENSE.md
  [✓] https://github.com/tcort/markdown-link-check/workflows/Test%20library/badge.svg

  9 links checked.

I use Portainer from Docker Desktop and I would like to know how to downgrade NODE_VERSION 21.7.1 to 20.12.2 and Yarn version 1.22.19 to 4.1.1. Is it possible to proceed by changing this via Dockerfile or others files, or other way ? Thanks a lot.

Capture d’écran 2024-04-12 à 17 33 14
MikeMcC399 commented 1 month ago

@valorisa

Edit: Apologies as I misread your report. I see you were actually using ghcr.io/tcort/markdown-link-check:3.12.1.

dklimpel commented 1 month ago

@MikeMcC399 Do you have a hint for a better image?

At the moment it is:

https://github.com/tcort/markdown-link-check/blob/71ccb4129a1fa86f6904f35c1b26348dfce1438d/Dockerfile#L1#

It is currently: sha: 3687802f25d2da52901b6a30d9bfaed81234b2ec63e52c01fbd1fc176fdbabbb

MikeMcC399 commented 1 month ago

@dklimpel

node:lts-alpine has Yarn 1.22.22 integrated

I guess that node:alpine (node:alpine:latest) & node:22.x-alpine3.x will catch up soon, however currently they are still on Yarn 1.22.19.

Since this is only a deprecation warning, you may just prefer to wait.