tcoulthard / caesar-lisflood

model
1 stars 2 forks source link

Creating config files from duplicating old ones can override option check box values #13

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Duplicating a config file (.xml) to use in a new simulation
2. Loading this config file and un-ticking an option that has subsidiary input 
values to fill in (Spatially variable rainfall in this case)
3. Changing the rainfall input file for one set up for uniform rain.
4. Saving the .xml config file and running the new simulation, with the 
appropriate new rainfall file.

What is the expected output? What do you see instead?
The simulation should run with uniform rainfall input and read a rainfall input 
file with a single column of values. Instead, the values from the old config 
file are 'preserved', and seem to cause the model to try and run with multiple 
rain cells (ignoring the un-checked option box). 

What version of the product are you using? On what operating system?
CAESAR-Lisflood 1.8a, Windows 7 64-bit.

Please provide any additional information below.
The problem is trivial to fix/avoid (although it does cause confusing output 
and is not immediately obvious what the cause is). Either create all config 
files from scratch, or remove the conflicting values in the GUI first.

Original issue reported on code.google.com by dva...@gmail.com on 7 Jan 2015 at 5:27

GoogleCodeExporter commented 9 years ago
I should add that I'm not 100% certain about the cause-effect, but removing the 
'old' values (hydroindex file, no. of rain cells) using the GUI seemed to fix 
the issue.

Original comment by dva...@gmail.com on 7 Jan 2015 at 5:31

GoogleCodeExporter commented 9 years ago
OK - I suspect the check box is there mainly to display or not display the 
different options (when checked) - and the code itself is deciding on whether 
or not to run in a multi rain cell way based on the values entered there...

I'll add this to the list of things to be updated when a new release is put out 
(its not critical I would suggest..)

Thanks for pointing it out,
Tom

Original comment by Tom.Coul...@gmail.com on 8 Jan 2015 at 2:27