Closed czlee closed 8 years ago
Did you accidentally include these commits in pull request #27? Seems like 27 should only include plot.py and the original plot files?
I asked him to make the two PRs have linear history. So it's fine to submit one that depends on the other.
On Mon, Feb 1, 2016 at 4:12 PM, Kexin Rong notifications@github.com wrote:
Did you accidentally include these commits in pull request #27 https://github.com/keithw/remy/pull/27? Seems like 27 should only include plot.py and the original plot files?
— Reply to this email directly or view it on GitHub https://github.com/keithw/remy/pull/28#issuecomment-178269241.
Split of #26 into semantically distinct histories.
opt=(m|b|r)
command that chooses which actions to optimize (leaving the others as defaults). This changes theConfigRange
class structure to pass more options to Remy, by adding newRatBreederOptions
andWhiskerImproverOptions
classes that are similar in purpose. (RatBreederOptions
contains instances of each ofWhiskerImproverOptions
andConfigRange
.) Neither of these currently have protobufs associated with them;WhiskerImproverOptions
is specified only from theopt=
in the command line.The
opt=
command should not, in theory, break any existing functionality, but I'm still testing this to be sure. If not specified it just optimizes for all three actions, as it did originally.