tcpexmachina / remy

403 stars 78 forks source link

Adding stochastic loss network element that randomly drops packets #49

Closed deeptir18 closed 7 years ago

deeptir18 commented 7 years ago

-This element, similar to Delay, Link, and Receiver, has a:

All it does is maintain a queue of packets to pass on to the next element, but uses a random seed to either drop or keep a packet before accepting the packet. I'm not 100 % sure that the next_event_time() function is completely accurate. The default loss_rate is set to 0, so all the regression tests should pass.

keithw commented 7 years ago

This looks really good! Couple of questions:

deeptir18 commented 7 years ago

(1) Sure I can easily break it up into small commits and redo the request.

(2) I was thinking about how Remy is used - should we treat stochastic loss like everyone of the other configurable network variables, so we can theoretically train over a range over networks with different stochastic loss rates? I guess that does make sense for some cases - you'd want to have a Remy resilient to different amounts of loss. My decision was slightly arbitrary.

keithw commented 7 years ago

This is the most beautifully explicated sequence of commits this project has ever received. :-) Bravo, and thanks for sticking with this!