999 :: Unexpected exception. Please log a bug on GitHub tcplugins/tcWebHooks. Exception was: null

[matt-richardson]

Expected Behavior

Using a project based webhook sensitive parameter for a bearer auth token should work.

Current Behavior

An error occurs:

999 :: Unexpected exception. Please log a bug on GitHub tcplugins/tcWebHooks. Exception was: null

Debugging it leads me to this line, where it uses previous when it could be null. It should be using newHookParameterModel instead.

Steps to Reproduce (for bugs)

1. Add a webhook parameter to your project
2. Set up a webhook
3. Enable bearer authentication
4. Run a build
5. See error on WebHook Execution History Details page

Your Environment

• tcWebHooks Version: 1.2.0-alpha.8
• TeamCity Version: 2022.04.3
• TeamCity server Operating System: linux
• Are you using a WebHook Template?: yes, but this happens with all of them

[netwolfuk]

Yes! You're right. Thank you @matt-richardson

It looks like a regression from a merge of the two feature branches. It previously was correct here

I'll reproduce and check your PR on the weekend. I need to be sure there are not any other sneaky issues of the same ilk. Alpha 9 on the weekend if I can.

[matt-richardson]

That'd be great - I've just shipped a thing that is intended to rely on these webhooks, so I'm super keen to get this fixed so I can unblock my other project!

Thanks for your help!

[netwolfuk]

Released https://github.com/tcplugins/tcWebHooks/releases/tag/v1.2.0-alpha9

[netwolfuk]

Thanks for your work on it @matt-richardson

[matt-richardson]

Wow. You are a legend. Thanks heaps, @netwolfuk!

[netwolfuk]

Haha. You did all the work. 😂

[netwolfuk]

I forgot to say, thank you for taking the time to test the alpha releases.

[matt-richardson]

No worries - my pleasure!

We've deployed the new version, and it's working a treat 🎉 . Thanks again!

[netwolfuk]

Release Candidate 1 released https://github.com/tcplugins/tcWebHooks/releases