search

tcr / corollary

Cross-compiler from Haskell to Rust, plus parser-haskell.
74 stars 6 forks source link

Attempted to rebase parse-C onto patterns #13

Closed pshc closed 7 years ago

pshc commented 7 years ago

I went ahead and tried to find happy resolution to the two branches.

We don't have to necessarily merge this PR; I just hope it helps with your current work.

tcr commented 7 years ago

Thank you for doing this! Let me do a quick check how this PR shakes out and update here.

tcr commented 7 years ago

Okay, I'm making the call that this is better off merged and improvements made as follow up PRs. Fewer large, outstanding diffs like #9 which touch a lot of code will help make collaborating easier I think.

@pshc You've been a great help. I added you as a collaborator; feel free to create branches directly on this repo. And you're free to land any PRs for small corrections or obvious changes, etc.

I'm going to have less time to make changes before the weekend but I'm still free to review PRs and contribute to issues.

pshc commented 7 years ago

Thank you! Hooray for increased ownership.

On Mon, May 15, 2017 at 9:05 PM Tim Ryan notifications@github.com wrote:

Okay, I'm making the call that this is better off merged and improvements made as follow up PRs. Fewer large, outstanding diffs like #9 https://github.com/tcr/corrode-but-in-rust/pull/9 which touch a lot of code will help make collaborating easier I think.

@pshc https://github.com/pshc You've been a great help. I added you as a collaborator; feel free to create branches directly on this repo. And you're free to land any PRs for small corrections or obvious changes, etc.

I'm going to have less time to make changes before the weekend but I'm still free to review PRs and contribute to issues.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/tcr/corrode-but-in-rust/pull/13#issuecomment-301646114, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAY_v5Oqz3U3Y_b7e0rCmekSPbGp1_Bks5r6PZqgaJpZM4Nb2cu .