search

tcr / rager

A pager written in Rust, like more or less.
https://crates.io/crates/rager
52 stars 12 forks source link

Italics, Underline, and Strikethrough support #10

Closed E5ten closed 5 years ago

E5ten commented 5 years ago

This switches rager to using my ransid fork and makes italics and underline support work. Fixes https://github.com/tcr/rager/issues/8

E5ten commented 5 years ago

I added strikethrough support to both ransid and rager, and I installed termite to test it because my terminal doesn't support strikethrough, it worked so I saw no reason not to add it to this.

tcr commented 5 years ago

Checked locally on my machine and it seemed to work with my test script, I think we can merge this as-is. Thanks for the PR!

tcr commented 5 years ago

Okay, just discovered I'm blocked on publishing to crates.io until we can no longer rely on a git dependency. So this will have to live in git master until we can upstream the other PR, or the dependent crate is vendored. cargo install --git https://github.com/tcr/rager -f continues to work though.

E5ten commented 5 years ago

I will make a pull request on ransid upstream tomorrow mornin and if it isn't merged after a while I could always make a new crate I guess.