Abort loading of corrupted history in order to avoid infinite loops

[jamacku]

Suggested by: @kdudka (Kamil Dudka)

[jamacku]

Hi @zoulasc, Thank you for fast response and patch 064853aa25f498aa7bc4554393a53240696813fa. unfortunately it still cause infinite loops while launching tcsh with corrupted history. We tried also switching seterror(...) for stderror(...) and it works fine.

Could you please review this patch? Is there any downside to this approach? There is also related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1846271

Thank you Kind regards Jan

[zoulasc]

There are 3 places actually... Committed, there is no downside since all these places are called from the history loading code.

Best,

christos

On Jul 30, 2020, at 6:45 AM, Jan Macku notifications@github.com wrote:

Hi @zoulasc https://github.com/zoulasc, Thank you for fast response and patch 064853a https://github.com/tcsh-org/tcsh/commit/064853aa25f498aa7bc4554393a53240696813fa. unfortunately it still cause infinite loops while launching tcsh with corrupted history. We tried also switching seterror(...) for stderror(...) and it works fine.

Could you please review this patch? Is there any downside to this approach? There is also related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1846271 https://bugzilla.redhat.com/show_bug.cgi?id=1846271 Thank you Kind regards Jan

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tcsh-org/tcsh/pull/28#issuecomment-666291565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENP5LPC2RU6DQMAGEYMXDR6FFLLANCNFSM4PNNUHGA.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tcsh-org/tcsh/pull/28#issuecomment-666291565", "url": "https://github.com/tcsh-org/tcsh/pull/28#issuecomment-666291565", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[zoulasc]

committed thanks!