tcsh-org / tcsh

This is a read-only mirror of the tcsh code repository.
https://www.tcsh.org/
Other
232 stars 42 forks source link

config.sub fails if building for "arm64" #46

Closed ngam closed 2 years ago

ngam commented 2 years ago

For some reason, config.sub expects arm-apple and doesn't accept arm64-apple.

Failing if it receives arm64-apple...

checking for a BSD-compatible install... /opt/homebrew/bin/ginstall -c
Invalid configuration `arm64-apple-darwin20.0.0': machine `arm64-apple' not recognized

Passing if it receives arm-apple...

checking for a BSD-compatible install... /opt/homebrew/bin/ginstall -c
checking build system type... arm-apple-darwin21.2.0
checking host system type... arm-apple-darwin21.2.0

A quick (and dirty) fix is to replace all mentions of arm to arm64 when building from a place where the machine is set to say arm64, e.g. mv config.sub config.sub_old; sed 's/arm/arm64/g' config.sub_old > config.sub. This is our temporary solution at conda-forge, see PR: https://github.com/conda-forge/tcsh-feedstock/pull/9/

It would probably be better if both arm64-apple and arm-apple are supported here. Thanks!

zoulasc commented 2 years ago

Should be fixed now!

christos

On Jan 3, 2022, at 10:15 PM, ngam @.***> wrote:

For some reason, config.sub expects arm-apple and doesn't accept arm64-apple.

Failing if it receives arm64-apple...

checking for a BSD-compatible install... /opt/homebrew/bin/ginstall -c Invalid configuration arm64-apple-darwin20.0.0': machinearm64-apple' not recognized Passing if it receives arm-apple...

checking for a BSD-compatible install... /opt/homebrew/bin/ginstall -c checking build system type... arm-apple-darwin21.2.0 checking host system type... arm-apple-darwin21.2.0

A quick (and dirty) fix is to replace all mentions of arm to arm64 when building from a place where the machine is set to say arm64, e.g. mv config.sub config.sub_old; sed 's/arm/arm64/g' config.sub_old > config.sub. This is our temporary solution at conda-forge, see PR: conda-forge/tcsh-feedstock#9 https://github.com/conda-forge/tcsh-feedstock/pull/9 It would probably be better if both arm64-apple and arm-apple are supported here. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/tcsh-org/tcsh/issues/46, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENP5K6QRAVMNHSNRM3EWTUUJQ6BANCNFSM5LGPG7TA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/tcsh-org/tcsh/issues/46", "url": "https://github.com/tcsh-org/tcsh/issues/46", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]