tcunit / TcUnit-Runner

Program that makes it possible to automate runs of TcUnit unit tests
Other
34 stars 17 forks source link

Changed amount into number. #20

Closed Roald87 closed 3 years ago

Roald87 commented 3 years ago

See also https://github.com/tcunit/TcUnit/pull/144

I didn't see any tests in this project. Only an empty Test project. Is it intended to be empty?

sagatowski commented 3 years ago

@Roald87 The tests folder is intended to have unit tests, but none so far. You're welcome to add of course!

sagatowski commented 3 years ago

Tested your changes with the TcUnit-Verifier, all seems to be working fine:

:\Code\GitHub_TcUnit\TcUnit-Runner\TcUnit-Runner\bin\Release>TcUnit-Runner.exe -v "C:\Code\GitHub_TcUnit\TcUnit\TcUnit-Verifier\TcUnit-Verifier_TwinCAT\TcUnit-Verifier_TwinCAT.sln"
2021-03-06 15:52:46 - TcUnit-Runner build: 0.9.3.0
2021-03-06 15:52:46 - TcUnit-Runner build date: 2021-03-06
2021-03-06 15:52:46 - Visual Studio solution path: C:\Code\GitHub_TcUnit\TcUnit\TcUnit-Verifier\TcUnit-Verifier_TwinCAT\TcUnit-Verifier_TwinCAT.sln
2021-03-06 15:52:46 -
2021-03-06 15:52:46 - In TwinCAT project file, found TwinCAT version 3.1.4022.32
2021-03-06 15:52:46 - In Visual Studio solution file, found visual studio version 12.0
2021-03-06 15:52:46 - Version is pinned: False
2021-03-06 15:52:46 - Trying to load the Visual Studio Development Tools Environment (DTE) version 'VisualStudio.DTE.12.0' ...
2021-03-06 15:52:48 - ...SUCCESSFUL!
2021-03-06 15:52:51 - Using the TwinCAT remote manager to load TwinCAT version '3.1.4024.12'...
2021-03-06 15:52:58 - No task name provided. Assuming only one task exists
2021-03-06 15:52:58 - Found task with name 'PlcTask'
2021-03-06 15:53:06 - Setting target NetId to '127.0.0.1.1.1'
2021-03-06 15:53:06 - Enabling boot project and setting BootProjectAutostart on 127.0.0.1.1.1
2021-03-06 15:53:30 - Waiting for results from TcUnit...
2021-03-06 15:53:40 - ... got 245 report lines so far.
2021-03-06 15:53:50 - ... got 771 report lines so far.
2021-03-06 15:54:01 - ... got 1296 report lines so far.
2021-03-06 15:54:12 - ... got 1371 report lines so far.
2021-03-06 15:54:13 - All results from TcUnit obtained
2021-03-06 15:54:23 - Done collecting TC results
2021-03-06 15:54:23 - Writing xUnit XML file to C:\Code\GitHub_TcUnit\TcUnit\TcUnit-Verifier\TcUnit-Verifier_TwinCAT\TcUnit_xUnit_results.xml
2021-03-06 15:54:23 - Closing the Visual Studio Development Tools Environment (DTE)...
2021-03-06 15:54:43 - Exiting application...
sagatowski commented 3 years ago

Also tested with a forced version of 3.1.4022.32, still seems to be fine:

C:\Code\GitHub_TcUnit\TcUnit-Runner\TcUnit-Runner\bin\Release>TcUnit-Runner.exe -v "C:\Code\GitHub_TcUnit\TcUnit\TcUnit-Verifier\TcUnit-Verifier_TwinCAT\TcUnit-Verifier_TwinCAT.sln" -w "3.1.4022.32"
2021-03-06 15:57:14 - TcUnit-Runner build: 0.9.3.0
2021-03-06 15:57:14 - TcUnit-Runner build date: 2021-03-06
2021-03-06 15:57:14 - Visual Studio solution path: C:\Code\GitHub_TcUnit\TcUnit\TcUnit-Verifier\TcUnit-Verifier_TwinCAT\TcUnit-Verifier_TwinCAT.sln
2021-03-06 15:57:14 -
2021-03-06 15:57:14 - In TwinCAT project file, found TwinCAT version 3.1.4022.32
2021-03-06 15:57:14 - In Visual Studio solution file, found visual studio version 12.0
2021-03-06 15:57:14 - Version is pinned: False
2021-03-06 15:57:14 - Trying to load the Visual Studio Development Tools Environment (DTE) version 'VisualStudio.DTE.12.0' ...
2021-03-06 15:57:17 - ...SUCCESSFUL!
2021-03-06 15:57:17 - The forced TwinCAT version is available
2021-03-06 15:57:17 - TwinCAT version is forced to 3.1.4022.32
2021-03-06 15:57:19 - Using the TwinCAT remote manager to load TwinCAT version '3.1.4022.32'...
2021-03-06 15:57:26 - No task name provided. Assuming only one task exists
2021-03-06 15:57:26 - Found task with name 'PlcTask'
2021-03-06 15:57:38 - Setting target NetId to '127.0.0.1.1.1'
2021-03-06 15:57:38 - Enabling boot project and setting BootProjectAutostart on 127.0.0.1.1.1
2021-03-06 15:58:03 - Waiting for results from TcUnit...
2021-03-06 15:58:13 - ... got 157 report lines so far.
2021-03-06 15:58:23 - ... got 658 report lines so far.
2021-03-06 15:58:34 - ... got 1183 report lines so far.
2021-03-06 15:58:45 - ... got 1370 report lines so far.
2021-03-06 15:58:46 - All results from TcUnit obtained
2021-03-06 15:58:56 - Done collecting TC results
2021-03-06 15:58:56 - Writing xUnit XML file to C:\Code\GitHub_TcUnit\TcUnit\TcUnit-Verifier\TcUnit-Verifier_TwinCAT\TcUnit_xUnit_results.xml
2021-03-06 15:58:56 - Closing the Visual Studio Development Tools Environment (DTE)...
2021-03-06 15:59:16 - Exiting application...
sagatowski commented 3 years ago

Thanks @Roald87 for your help & commitment to this project!