search

tcunit / TcUnit-Runner

Program that makes it possible to automate runs of TcUnit unit tests
Other
34 stars 17 forks source link

Fixes #28: BuildSolution Hangs after CleanSolution #32

Closed densogiaichned closed 2 years ago

densogiaichned commented 2 years ago

This PR fixes issue #28 (and closed #5).

Caching the EnvDTE.SolutionBuild object made the build process much more stable/reliable. Adding a additional "cool down", aka Thread.Sleep, should also improve the process.

We had this issue only on our build pipeline (self-hosted GitHub runner with TcXaeShell on a VM), not locally on the dev-machine, which was also mentioned in the issues.

sagatowski commented 2 years ago

@densogiaichned Thanks for creating this PR, it's fantastic that you've had the time to look deeper into this! I'll look into it soon and merge it. I'll however cherry-pick only the first commit as the version 0.9.4 is the current working version (latest release is 0.9.3).

Have you had an opportunity to test this with something else than the TcXaeShell? (Like VS2019)?

sagatowski commented 2 years ago

Merged into master. Thanks @densogiaichned ! You are still welcome to check whether you've got the same behaviour on VS2019.

densogiaichned commented 2 years ago

Hi @sagatowski , made some test regarding VS2019, had no issues so far... (tested on the local dev-machine, so take this with a grain of salt)

sagatowski commented 2 years ago

Thanks @densogiaichned !