search

tcunit / TcUnit-Runner

Program that makes it possible to automate runs of TcUnit unit tests
Other
34 stars 17 forks source link

Lacking flexibility on ErrorList entry processing for newer VS environments #4

Closed davidlonghowick closed 3 years ago

davidlonghowick commented 3 years ago

TwinCAT projects created in Visual Studio versions newer than 2013 don't have default ErrorList order setting, which means that the ErrorList entries are not ordered in the expected format for TcUnit-runner to parse (TcUnitResultCollector ln 122-375).

sagatowski commented 3 years ago

Excellent catch! Do you know if it's possible to change the errorlist ordering by the DTE?

sagatowski commented 3 years ago

I've tested this and can confirm that the same behaviour occurs with VS2013. VS2013 simply just remembers the last sorting-setting that you have for the errorlist, and applies that to the list that gets returned.

@davidlonghowick If you can find a nice solution to this it would be appreciated.

sagatowski commented 3 years ago

I haven't managed to find any way to sort the data coming directly from the DTE, so I guess we need to apply the same sorting that visual studio does when clicking the "Description"-field. This should be done on either the: ErrorItems errorItems or the List<ErrorList.Error> errors

sagatowski commented 3 years ago

@davidlonghowick - I've done a fix, can you do a clone of the repo, compile the TcUnit-Runner and see whether it fixes the issue?

davidlonghowick commented 3 years ago

@davidlonghowick - I've done a fix, can you do a clone of the repo, compile the TcUnit-Runner and see whether it fixes the issue?

Tested and it appears resolved. Appreciate the quick response, currently using this on an Azure VM for a CI pipeline and really needed the unit testing running!

sagatowski commented 3 years ago

@davidlonghowick Great that it seems to fix the issue! I'll do some more testing and then do a formal release during the weekend. Thanks for reporting this issue!

sagatowski commented 3 years ago

Solved in 533a21a. Created new release (0.9.1).