search

tcunit / TcUnit

An unit testing framework for Beckhoff's TwinCAT 3
Other
271 stars 74 forks source link

AreAllTestsFinished() should be PUBLIC #140

Closed sagatowski closed 3 years ago

sagatowski commented 3 years ago

Hello Jacob, in the TcUnit version 1.1.0.0 you declared this method as PUBLIC. " FB_TestSuite.AreAllTestsFinished() " After the implementation of these functions ( RUN_IN_SEQUENCE(FUN) and TEST_IN_ORDERED(FUN) in a branch, you now declared this method as INTERNAL. Because i use this method outsite the TcUniit. Can you declare this method as PUBLIC? Thank you for the answer. Have a nice day. Yok Menns

Originally posted by @YokMenns in https://github.com/tcunit/TcUnit/discussions/127#discussioncomment-284694

Roald87 commented 3 years ago

Same for FB_TestSuite.GetNumberOfTests, FB_Test.IsFinished and FB_Test.IsFailed. Maybe also more. I think these methods/variables are convenient if the user wants to write some custom methods/function blocks.

Roald87 commented 3 years ago

Same for FB_TestSuite.GetNumberOfTests, FB_Test.IsFinished and FB_Test.IsFailed. Maybe also more. I think these methods/variables are convenient if the user wants to write some custom methods/function blocks.

What about those?

YokMenns commented 3 years ago

FB_Test.IsFinished is still INTERNAL.

sagatowski commented 3 years ago

@YokMenns You wrote: "in the TcUnit version 1.1.0.0 you declared this method as PUBLIC. " FB_TestSuite.AreAllTestsFinished() ""

For FB_Test.IsFinished() you should use IS_TEST_FINISHED() instead