AddAssertResult not checking limits of AssertResults array

tcunit / TcUnit

An unit testing framework for Beckhoff's TwinCAT 3

Other

258 stars 72 forks source link

AddAssertResult not checking limits of AssertResults array #190

Closed doerk77 closed 9 months ago

doerk77 commented 2 years ago

Describe the bug When increasing TotalAsserts in method AddAssertResult the array limits of AssertResults are not being checked, causing PLC crash due to invalid array index.

Expected behavior Prevent crash by limit checks and sending error through ADSLOGSTR. Remark: Prevent overflow of event logger (error should only be raised once)!!!

Screenshots

Software versions v1.2.0.0

has been mentioned earlier in #153

sagatowski commented 2 years ago

Pull request welcome.

sagatowski commented 9 months ago

Solved in #193 & in commit 4a48bdd