search

tcunit / TcUnit

An unit testing framework for Beckhoff's TwinCAT 3
Other
258 stars 72 forks source link

Duration is not calculated when running tests in sequence #210

Closed sagatowski closed 9 months ago

sagatowski commented 1 year ago

Describe the bug Whenever running tests in sequence (any of the examples here, the duration is always calculated to be 0.0.

To Reproduce Clone the latest master, run any of the examples above, and see the duration be 0.0.

Expected behavior Duration should be correctly calculated, just like in the case when running tests that are not in sequence (so running in parallell).

Screenshots image

Software versions TwinCAT 3.1.4024.44. Visual Studio 2019 (according to the contributing guidelines). TcUnit from master.

Run environment Running in virtual machine.

Additional context Note that build-chain for TcUnit has been updated. Please look at Contributing markdown file.

sagatowski commented 1 year ago

@stefanbesler I just merged your changes in. Unfortunately, not everything works. See above. Could you look into it? Note that the build-chain (tools) have been changed now (see contributing guidelines).

sagatowski commented 1 year ago

Initial fix done. Needs to be tested more. See #211 for the details.

stefanbesler commented 9 months ago

Hm, not sure what went wrong here. What’s left to do, where can I help?

sagatowski commented 9 months ago

Hey! I ran all the timed/sequence examples to verify everything is fine now and it looks good. I've realized it's a little annoying to run these manually to verify that the functionality is OK. Will have to think of a way to automate this.